Fix for Default MD5 check getting skipped even when http checksum algorithm is not set #3748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joviegas
force-pushed
the
joviegas/checksum_and_crc32
branch
2 times, most recently
from
3c9e027 to
9b03a7b
Compare
…orithm is not set
joviegas
force-pushed
the
joviegas/checksum_and_crc32
branch
from
9b03a7b to
120fc96
Compare
millems
reviewed
Feb 7, 2023
| @@ -0,0 +1,6 @@ | |||
| { | |||
| "type": "bugfix", | |||
| "category": "AWS SDK for Java v2", | |||
millems
approved these changes
Feb 7, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
By default for putRequest Md5 checksum validation should happen. By default as in when the new http checksum is not set to any algorithm.
Currently it was skipping since the check was directly checking for ResolvedChecksum specs even when request algorithm were null.
Note that this validation is done in S3 when httpChecksum algorithm is set.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
License