[IMDS] Token cache for Async client #3649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-Applin
changed the title
millems
reviewed
Jan 4, 2023
| waitingFutures.add(result); | ||
| } else { | ||
| CompletableFuture<Token> tokenRequest = startRefresh(result); | ||
| CompletableFutureUtils.forwardExceptionTo(result, tokenRequest); |
Contributor
There was a problem hiding this comment.
We probably don't want this. A cancellation of the result future probably shouldn't fail the refresh that's happening in the background, because other (unrelated) calls might be waiting on that refresh.
Contributor
Author
There was a problem hiding this comment.
I see what you mean. I think it's fine to remove it because we will still cancel the request made with the token after, it's only the token refresh call that would be not be cancellable by the users.
millems
reviewed
Jan 4, 2023
core/imds/src/main/java/software/amazon/awssdk/imds/internal/AsyncTokenCache.java
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/internal/AsyncTokenCache.java
Outdated
Show resolved
Hide resolved
core/imds/src/main/java/software/amazon/awssdk/imds/internal/AsyncTokenCache.java
Outdated
Show resolved
Hide resolved
- remove future error forwarding to cached request - replace future forward test by checking that no http requests were made - moved fragile tests to their owned class to prevent potential different results on different runs - added Test constants
|
SonarCloud Quality Gate failed.
|
millems
approved these changes
Jan 10, 2023
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Feb 11, 2025
Minor fixes to address feedback and update changelog file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Required as part of the async IMDS Client. The async client also needs to cache the token and reuse it if it is not expired on subsequent requests.
Modifications
Added AsyncTokenCache class, caching the token and returning a CompletableFuture.
Removed TokenCacheStrategy.
Moved some async HTTP request logic to an helper class.
Added log + javadoc.
Testing
Update async unit test to make them slightly more robust.
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License