Skip to content

Update EnhancedAttributeValue to accept Collection #3516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 26, 2022

Conversation

L-Applin
Copy link
Contributor

resolves 3453 by adding overloads that accept java.util.Collection to the fromSetOf* methods.

Motivation and Context

resolves 3453

Modifications

Adds new methods in EnhancedAttributeValue that accepts Collection instances

Testing

New unit tests for the new methods.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds **some tests fails, but not related to the changes of this PR
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@L-Applin L-Applin requested a review from a team as a code owner October 25, 2022 15:10
@L-Applin L-Applin linked an issue Oct 25, 2022 that may be closed by this pull request
2 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@L-Applin L-Applin merged commit fa1ac02 into master Oct 26, 2022
@L-Applin L-Applin deleted the olapplin/dynamodb-enhanced-collection branch October 26, 2022 16:06
debora-ito pushed a commit to debora-ito/aws-sdk-java-v2 that referenced this pull request Oct 28, 2022
* Update EnhancedAttributeValue to accept Collection for fromSetOf* methods

* Update EnhancedAttributeValue to accept Collection for fromSetOf* methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB EnhancedAttributeValue "set" operations should accept sets
2 participants