Disable MD5 checksum at S3 CRT client creation time and propagate checksum algorithm #3309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
cenedhryn
force-pushed
the
salande/tm-disable-md5
branch
from
1d99639 to
44f27b6
Compare
|
Did we do a integ testing and check if the requests are succeeded ? |
joviegas
reviewed
Jul 21, 2022
| ChecksumSpecs checksumSpecs = asyncRequest.httpExecutionAttributes().getAttribute(CHECKSUM_SPECS); | ||
| if (checksumSpecs != null && checksumSpecs.algorithm() != null) { | ||
| Algorithm checksumAlgorithm = checksumSpecs.algorithm(); | ||
| switch (checksumAlgorithm) { |
There was a problem hiding this comment.
Can we use Enum.fromValue(str.toUpper/LowerCase) here instead of switch case ?
| @@ -160,10 +161,11 @@ public void afterMarshalling(Context.AfterMarshalling context, | |||
| SdkHttpExecutionAttributes.builder() | |||
| .put(OPERATION_NAME, | |||
| executionAttributes.getAttribute(SdkExecutionAttribute.OPERATION_NAME)) | |||
| .put(CHECKSUM_SPECS, | |||
| executionAttributes.getAttribute(SdkExecutionAttribute.RESOLVED_CHECKSUM_SPECS)) | |||
There was a problem hiding this comment.
I see we do a
getAttribute(SdkExecutionAttribute.RESOLVED_CHECKSUM_SPECS)
where is SdkExecutionAttribute.RESOLVED_CHECKSUM_SPECS updated with resolved in case of code flow for transfer manager execution ?
|
Closing in favor of #3376 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License