Honor content-length set on request body #3123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
force-pushed
the
gh2908
branch
5 times, most recently
from
b0f50cc to
f2f927d
Compare
zoewangg
reviewed
Mar 25, 2022
...dk-core/src/main/java/software/amazon/awssdk/core/internal/io/SdkLengthAwareInputStream.java
Outdated
Show resolved
Hide resolved
...dk-core/src/main/java/software/amazon/awssdk/core/internal/io/SdkLengthAwareInputStream.java
Outdated
Show resolved
Hide resolved
zoewangg
approved these changes
Mar 28, 2022
This commit ensures that when a RequestBody is created with an InputStream, the content-length also set on the RequestBody is honored, regardless of how much extra data is available in the stream. Note that if less data is actually available in the wrapped stream, this implmenetation will return EOF as well. Fixes aws#2908
Contributor
Author
|
The two bugs identified by SonarCloud are the same bug:
I've resolved them as won't fix because this class isn't meant to be threadsafe. |
|
Kudos, SonarCloud Quality Gate passed! |
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jul 29, 2024
…c7772a7cf Pull request: release <- staging/986b8bd4-c7b6-4cba-b7ef-af9c7772a7cf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Bug fix.
Modifications
This commit ensures that when a RequestBody is created with an InputStream, the
content-length also set on the RequestBody is honored, regardless of how much
(extra) data is avaialble in the stream.
Fixes #2908
Testing
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License