Skip to content

Add default RegionScope for SigV4a signers #3025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2022
Merged

Conversation

dagnir
Copy link
Contributor

@dagnir dagnir commented Feb 11, 2022

Motivation and Context

Support certain customer use cases where setting a custom region scope is necessary.

Modifications

This commit adds support for setting the default RegionScope used by the Sigv4a
signer implementations. If the region scope to use is not supplied to the
signing methods, the signers will default to this scope first and then the
normal signing region.

Testing

New unit tests.

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

This commit adds support for setting the default RegionScope used by the Sigv4a
signer implementations. If the region scope to use is not supplied to the
signing methods, the signers will default to this scope first and then the
normal signing region.
@dagnir dagnir marked this pull request as ready for review February 12, 2022 00:13
@dagnir dagnir requested a review from a team as a code owner February 12, 2022 00:13
@dagnir dagnir enabled auto-merge (squash) February 15, 2022 20:53
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

27.4% 27.4% Coverage
9.9% 9.9% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants