-
Notifications
You must be signed in to change notification settings - Fork 910
Add default RegionScope for SigV4a signers #3025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for setting the default RegionScope used by the Sigv4a signer implementations. If the region scope to use is not supplied to the signing methods, the signers will default to this scope first and then the normal signing region.
joviegas
approved these changes
Feb 14, 2022
millems
reviewed
Feb 14, 2022
core/regions/src/main/java/software/amazon/awssdk/regions/RegionScope.java
Outdated
Show resolved
Hide resolved
joviegas
approved these changes
Feb 15, 2022
millems
approved these changes
Feb 15, 2022
joviegas
approved these changes
Feb 15, 2022
SonarCloud Quality Gate failed. |
aws-sdk-java-automation
added a commit
that referenced
this pull request
May 7, 2024
…90b51ed73 Pull request: release <- staging/021be9d5-4d95-4774-a169-66a90b51ed73
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Support certain customer use cases where setting a custom region scope is necessary.
Modifications
This commit adds support for setting the default RegionScope used by the Sigv4a
signer implementations. If the region scope to use is not supplied to the
signing methods, the signers will default to this scope first and then the
normal signing region.
Testing
New unit tests.
Screenshots (if appropriate)
Types of changes
Checklist
mvn install
succeedsscripts/new-change
script and following the instructions. Commit the new file created by the script in.changes/next-release
with your changes.License