Fix @Ignored kinesis integration test to not test service behavior. #2906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagnir
approved these changes
Dec 9, 2021
Contributor
Author
There was a problem hiding this comment.
There's a lot of printlns. Should I remove them all?
millems
force-pushed
the
millem/debug-kinesis-test
branch
from
14c881e to
dd9e113
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
dagnir
approved these changes
Dec 10, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Feb 22, 2024
…e8abcbd93 Pull request: release <- staging/5b4794e1-0c61-4004-b467-199e8abcbd93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like this test started to fail because Kinesis changed the way merging shards worked - with records not being lost in merging. That makes sense, but we relied on the old behavior. Instead of just updating the assertions, updated the test to test less of the service's behavior without testing much less of the SDK behavior.