[JUnit 5] Migrate some parameterized tests to JUnit 5 #2880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JUnit 4 -> 5 migrations are often done in a 3-step process: 1. Update dependencies to JUnit 5, including the vintage module, causing all tests to leverage the new JUnit 5 Platform 2. Incrementally migrate JUnit 4 tests to JUnit 5 tests 3. Once no JUnit 4 usage remains, remove the dependency on the vintage module This PR continues step 2 by migrating some parameterized tests to JUnit 5.
cenedhryn
reviewed
Dec 2, 2021
Contributor
cenedhryn
left a comment
cenedhryn
left a comment
There was a problem hiding this comment.
The new API is more intuitive IMO!
zoewangg
approved these changes
Dec 2, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Dec 3, 2021
This reverts commit e2915d0.
aws-sdk-java-automation
pushed a commit
that referenced
this pull request
Dec 3, 2021
Revert "[JUnit 5] Migrate some parameterized tests to JUnit 5 (#2880)"
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 31, 2024
…a131f31e5 Pull request: release <- staging/590b85ab-f197-473d-a0c3-616a131f31e5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JUnit 4 -> 5 migrations are often done in a 3-step process:
This PR continues step 2 by migrating some parameterized tests to JUnit 5.
License