Resubmit: "[JUnit 5] Migrate to JUnit 5 Platform (with existing JUnit 4 test cases)" #2857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
joviegas
approved these changes
Nov 20, 2021
aws-sdk-java-automation
added a commit
that referenced
this pull request
Jan 13, 2024
…3c3006142 Pull request: release <- staging/5673c154-22fb-4a49-8b74-d2b3c3006142
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resubmits the changes in #2850 by undoing the revert performed in commit adc2072. The previous change failed for integration tests. This PR resubmits the same changes and will be used for tracking any necessary fixes in the integration tests.
Previous builds were failing due to errors like:
This appears to have been due to having conflicting version of junit4 pulled in from different transitive dependencies. Specifying the version to use in the top-level pom's
dependencyManagement, and making sure the version was consistent with the version pulled in byjunit-vintage-engineappears to have resolved this issue.