Skip to content

Conversation

@mina-asham
Copy link

@mina-asham mina-asham commented Apr 2, 2020

See issue: #1754

Description

  • Add support for ProfileFile know when it's been updated on disk and to reload in a new immutable version.
  • Add support for ProfileCredentialsProvider when the ProfileFile is updated on disk

Motivation and Context

This was the behaviour in SDK V1, it's also a kind of bug because it not mentioned in the 1.11 to 2.x change log (caused me a bug trying to migrate)

Testing

Added unit tests for new functionality, ran mvn install to verify it doesn't affect anything else.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • A short description of the change has been added to the CHANGELOG
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@codecov-io
Copy link

codecov-io commented Apr 2, 2020

Codecov Report

Merging #1760 into master will increase coverage by 0.01%.
The diff coverage is 96.52%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1760      +/-   ##
============================================
+ Coverage     76.26%   76.28%   +0.01%     
  Complexity      182      182              
============================================
  Files          1070     1072       +2     
  Lines         32209    32263      +54     
  Branches       2514     2526      +12     
============================================
+ Hits          24564    24611      +47     
+ Misses         6409     6408       -1     
- Partials       1236     1244       +8     
Flag Coverage Δ Complexity Δ
#unittests 76.28% <96.52%> (+0.01%) 182.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...ssdk/enhanced/dynamodb/mapper/BeanTableSchema.java 85.12% <91.42%> (-1.12%) 0.00 <0.00> (ø)
...k/auth/credentials/ProfileCredentialsProvider.java 80.76% <94.73%> (-3.45%) 0.00 <0.00> (ø)
...igner/internal/BaseEventStreamAsyncAws4Signer.java 95.29% <100.00%> (+0.29%) 0.00 <0.00> (ø)
...a/software/amazon/awssdk/profiles/ProfileFile.java 84.90% <100.00%> (+3.72%) 0.00 <0.00> (ø)
.../enhanced/dynamodb/AttributeConverterProvider.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
...ed/dynamodb/DefaultAttributeConverterProvider.java 97.80% <100.00%> (ø) 0.00 <0.00> (?)
...odb/internal/converter/ChainConverterProvider.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
.../internal/converter/ConverterProviderResolver.java 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...dk/enhanced/dynamodb/mapper/StaticTableSchema.java 90.17% <100.00%> (+0.08%) 0.00 <0.00> (ø)
...http/nio/netty/internal/nrs/HandlerSubscriber.java 75.86% <0.00%> (-6.90%) 0.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1031b29...6a2a3c4. Read the comment docs.

… changes on disk

- Add support for ProfileFile know when it's been updated on disk and to reload in a new immutable version.
- Add support for ProfileCredentialsProvider when the ProfileFile is updated on disk
@mina-asham mina-asham force-pushed the refreshable-profile-credentials-provider branch from ff219b5 to 6a2a3c4 Compare April 2, 2020 12:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 2, 2020

SonarCloud Quality Gate failed.

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 6 Code Smells

81.0% 81.0% Coverage
0.0% 0.0% Duplication

@debora-ito
Copy link
Member

@mina-asham As mentioned in #3487 we are working on this feature request but decided on a solution that is different from the one you suggested here. I'll go ahead and close this. We appreciate your effort and time working on this PR!

@debora-ito debora-ito closed this Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants