Exceptions raised from ExecutionInterceptor.modifyHttpRequest do not cause ExecutionInterceptor.onExecutionFailure to be invoked.

[millems]

Exceptions raised from ExecutionInterceptor.modifyHttpRequest do not cause ExecutionInterceptor.onExecutionFailure to be invoked. Review and ensure that onExecutionFailure will always be invoked if complete-execution isn't invoked.

[zoewangg]

Some interceptor methods such as modifyHttpRequest are invoked in ClientHandler and are not part of the RequestPipeline in AmazonSyncHttpClient/AmazonAsyncHttpClient and that's why it has never gone to the ExecutionFailureExceptionReportingStage and fired onExeuctionFailure.

We can either move all the interceptor executions to the RequestPipeline if it's possible (Major Changes but easier to manage in the long term)
or
try catch exceptions in ExecutionInterceptorChain for those execution methods and explicitly call onExecutionFailure there like the following. (Small changes)

    public InterceptorContext modifyRequest(InterceptorContext context, ExecutionAttributes executionAttributes) {
        try {
            return doModifyRequest(context, executionAttributes);
        } catch (Exception e) {
            onExecutionFailure(new DefaultFailedExecutionContext(context, e), executionAttributes);
            throw e;
        }
    }

[millems]

Reminder to readers that +1s and comments on this issue can help it get prioritized, if you're impacted.

[ndejaco2]

+1