Redundant byte array copying in AsyncRequestBody

[RoKish]

Describe the bug

It doesn't make sense to copy a byte array in AsyncRequestBody#fromBytes and AsyncRequestBody#fromByteBuffer since the byte array is copied in the constructor of ByteArrayAsyncRequestBody afterwards.

Possible Solution

I think the best solution will be to copy the byte array in the constructor of ByteArrayAsyncRequestBody. Another constructor should be added to accept offset and length in order to support copying from ByteBuffer.

Your Environment

• AWS Java SDK version used: 2.7.15

[debora-ito]

@RoKish seems reasonable, but it's more an enhancement than a bug.

If you can send us a PR, we'll be happy to take a look.

[millems]

Fixed by #3925

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[millems]

@all-contributors please add @StephenFlavin for code