-
Notifications
You must be signed in to change notification settings - Fork 718
feat: add support for per service options to Config #3145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for per service options to Config #3145
Conversation
You're going to need to regenerate the service clients since this includes a codegen change. |
Service clients have been regenerated. All api_client.go files now include the ApplyServiceOptions call. @lucix-aws Let me know if i'm missing something here. |
@lucix-aws Is there anything still pending for this change? |
I'll try to find time to look at it again this week. |
Ignore failing integration tests and codegen tests. |
Summary
Implements the feature requested in #3141 to allow
aws.Config
to hold service specific options that are automatically applied during client construction.Problem
Currently, service specific options must be manually passed to each client creation:
Solution
Add service-specific options to
aws.Config
that are automatically applied during client construction:Related Issue
Closes #3141