Handle S3 API failures that return 200 OK #783
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The SDK relies on HTTP status codes to determine whether or not the operation succeeded. However, in certain APIs such as CompleteMultipartUpload, the API may return 200 OK with an error in the response body. In those cases, the response body needs to be inspected for errors. This fix only checks response bodies of non-GET requests that return XML as the response type.
amsa
changed the title
|
I don't have a better solution. |
|
Greetings! Sorry to say but this is a very old issue that is probably not getting as much attention as it deservers. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to open a new one. |
github-actions
bot
added
closing-soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK relies on HTTP status codes to determine whether or not the operation succeeded. However, in certain APIs such as CompleteMultipartUpload, the API may return 200 OK with an error in the response body. In those cases, the response body needs to be inspected for errors. This fix only checks response bodies of non-GET requests that return XML as the response type. #658 #781