S3Client::CompleteMultipartUpload returns success for failed requests

[dyfrgi]

Complete Multipart Upload is a bit weird in the REST API. Rather than return a failed HTTP code for a failure, it returns 200 OK immediately and then may later, at its leisure, send back an error. This is described in the API docs here:
http://docs.aws.amazon.com/AmazonS3/latest/API/mpUploadComplete.html

However, if an error is received for a Complete Multipart Upload along with a 200 OK, as described in the example given in the doc there, the CompleteMultipartUploadOutcome returned by S3Client::CompleteMultipartUpload will have have IsSuccess()==true.

We are specifically receiving 200 OK SlowDown errors, but I expect other errors may occur as there's one given as an example in the API doc.

[JonathanHenson]

Thanks for reporting will get it queued up for fix.

[marcomagdy]

This has been fixed in v1.3.30

[marcomagdy]

We'll have to revert this change f5c0f79 See #781 for more details.

[andriy-bulynko]

Hi! We're hitting this bug as well. Do you have any idea when you might post a fix? Thanks!

[pitrou]

Why isn't this still fixed? This sounds like a critical bug. We just got word that our users can be hit by it: https://issues.apache.org/jira/browse/ARROW-14523

[pitrou]

@wps132230 @sdavtaker @KaibaLopez

[pitrou]

I'll also note that the docstring, while stating the problem, is unhelpful as to how to solve it:

Processing of a Complete Multipart Upload request could take several minutes to complete. After Amazon S3 begins processing the request, it sends an HTTP response header that specifies a 200 OK response. While processing is in progress, Amazon S3 periodically sends white space characters to keep the connection from timing out. Because a request could fail after the initial 200 OK response has been sent, it is important that you check the response body to determine whether the request succeeded.