Skip to content

Mingw-w64 compilation support #1836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slonm opened this issue Jan 4, 2022 · 3 comments
Closed

Mingw-w64 compilation support #1836

slonm opened this issue Jan 4, 2022 · 3 comments
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member.

Comments

@slonm
Copy link

slonm commented Jan 4, 2022

I would like contribute Mingw-w64 compilation support. It requires:

  • Changed case of Windows headers to lower case
  • Added undefine WinAPI defines for "interface", "GetObject", "ERROR" when names clash appear
  • removed -fPIC compiler option for Windows
  • Replace _WIN32 to _MSC_VER or viceversa when needed

Changes affect to aws-sdk-cpp project and crt dependent projects.

Changes to aws-sdk-cpp provided in PR #1832

Can anybody help me make contribution correctly?
@slonm slonm added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2022
@jmklix jmklix linked a pull request Jan 4, 2022 that will close this issue
Mingw-w64 compilation support: #1832
Closed
@KaibaLopez
Copy link
Contributor

Hi @slonm ,
Thanks for the feature request and the PRs!

@KaibaLopez KaibaLopez added needs-review This issue or pull request needs review from a core team member. and removed needs-triage This issue or PR still needs to be triaged. labels Jan 5, 2022
@jmklix
Copy link
Member

jmklix commented Jan 6, 2022

Thanks for taking the time to create the PR, but we have decided to not accept it right now. It can be difficult to support any additional complexities that may arise because of this so I will be closing this feature request and the related PR

@jmklix jmklix closed this as completed Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Feb 26, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-review This issue or pull request needs review from a core team member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mingw-w64 compilation support: slonm/aws-sdk-cpp
3 participants
@slonm @jmklix @KaibaLopez