Skip to content

Conversation

@aahung
Copy link
Contributor

@aahung aahung commented Dec 21, 2020

Which issue(s) does this change fix?

Why is this change necessary?

boto3 has been stable among minor version upgrades,
we can make the version requirement loose as we do in
aws/serverless-application-model#1812

How does it address the issue?

What side effects does this change have?

Checklist

  • Write design document (Do I need to write a design document?)
  • Write unit tests
  • Write/update functional tests
  • Write/update integration tests
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

boto3 has been stable among minor version upgrades,
we can make the version requirement loose as we do in
aws/serverless-application-model#1812
@aahung
Copy link
Contributor Author

aahung commented Dec 21, 2020

Context: #2389 (comment)

@aahung aahung merged commit 5e794f0 into aws:develop Jan 4, 2021
@aahung aahung deleted the loose-boto3 branch January 4, 2021 21:00
aahung added a commit to aahung/aws-sam-cli that referenced this pull request Jan 5, 2021
aahung added a commit that referenced this pull request Jan 6, 2021
* * Revert "Revert "chore: Enable basic mypy typechecking""

This brings back commit 9d29984.

* chore: Enable basic mypy typechecking, 2nd round after reverting

* Remove import from builtins

* Loose boto3-stubs version, matching boto3 #2493
mndeveci added a commit to mndeveci/aws-sam-cli that referenced this pull request Jan 19, 2021
boto3 has been stable among minor version upgrades,
we can make the version requirement loose as we do in
aws/serverless-application-model#1812

Co-authored-by: Mohamed Elasmar <[email protected]>
Co-authored-by: Mehmet Nuri Deveci <[email protected]>
mndeveci pushed a commit to mndeveci/aws-sam-cli that referenced this pull request Jan 19, 2021
* * Revert "Revert "chore: Enable basic mypy typechecking""

This brings back commit 9d29984.

* chore: Enable basic mypy typechecking, 2nd round after reverting

* Remove import from builtins

* Loose boto3-stubs version, matching boto3 aws#2493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants