Skip to content

Conversation

chenwany
Copy link
Contributor

@chenwany chenwany commented Oct 21, 2022

Description of changes

  • tabulate 0.8.7 doesn't work well with python3.10
    With tabulate version 0.8.7 and python 3.10, pcluster configure doesn't work correctly.
    the error with running pcluster configure is
2022-10-21 14:17:59,236 - INFO - entrypoint.py:226:run() - Handling CLI command configure
2022-10-21 14:17:59,236 - INFO - entrypoint.py:227:run() - Parsed CLI arguments: args(Namespace(operation='configure', region=None, config='/test', func=<bound method ConfigureCommand.execute of <pcluster.cli.commands.configure.command.ConfigureCommand object at 0x105535d20>>, expects_extra_args=False)), extra_args([])
2022-10-21 14:17:59,238 - ERROR - entrypoint.py:256:main() - Unexpected error of type ImportError: cannot import name 'Iterable' from 'collections' (/usr/local/Cellar/[email protected]/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/collections/__init__.py)
Traceback (most recent call last):
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/entrypoint.py", line 234, in main
    ret = run(sys.argv[1:])
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/entrypoint.py", line 228, in run
    return _run_operation(model, args, extra_args)
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/entrypoint.py", line 197, in _run_operation
    return args.func(args, extra_args)
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/commands/configure/command.py", line 36, in execute
    from pcluster.cli.commands.configure.easyconfig import configure
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/commands/configure/easyconfig.py", line 24, in <module>
    from pcluster.cli.commands.configure.networking import (
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/commands/configure/networking.py", line 22, in <module>
    from pcluster.cli.commands.configure.utils import handle_client_exception
  File "/Users/chenwany/python310/lib/python3.10/site-packages/pcluster/cli/commands/configure/utils.py", line 18, in <module>
    from tabulate import tabulate
  File "/Users/chenwany/python310/lib/python3.10/site-packages/tabulate.py", line 16, in <module>
    from collections import Iterable
ImportError: cannot import name 'Iterable' from 'collections' (/usr/local/Cellar/[email protected]/3.10.8/Frameworks/Python.framework/Versions/3.10/lib/python3.10/collections/__init__.py)

Tests

  • Test with python 3.10 and tabulate 0.8.7 --not ok
  • Test with python 3.10 and tabulate 0.8.8 --not ok
  • Describe the added/modified tests.

References

  • Link to related PRs in other packages (i.e. cookbook, node).
  • Link to documentation useful to understand the changes.

Checklist

  • Make sure you are pointing to the right branch and add a label in the PR title (i.e. 2.x vs 3.x)
  • Check all commits' messages are clear, describing what and why vs how.
  • Make sure to have added unit tests or integration tests to cover the new/modified code.
  • Check if documentation is impacted by this change.

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

tabulate 0.8.7 doesn't work well with python3.10

Signed-off-by: chenwany <[email protected]>
@chenwany chenwany requested review from a team as code owners October 21, 2022 21:35
@chenwany chenwany added skip-changelog-update Disables the check that enforces changelog updates in PRs 3.x labels Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #4477 (517bbaa) into develop (d8c2cb6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4477   +/-   ##
========================================
  Coverage    88.81%   88.81%           
========================================
  Files          160      160           
  Lines        13786    13786           
========================================
  Hits         12244    12244           
  Misses        1542     1542           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@francesco-giordano francesco-giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenwany chenwany merged commit 709e909 into aws:develop Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants