Skip to content

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented Nov 17, 2022

Issue #, if available:

#704 Event kinds not shown in SQS mode

Description of changes:

  • Show actual event kinds in Queue mode
  • Emit pod events on drain
  • Make changes "opt-in" via Helm chart logFormatVersion

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

* feat: emit pod events on drain
* feat: make log format selectable

Co-authored-by: Jerad C <[email protected]>
@cjerad cjerad requested a review from snay2 November 17, 2022 21:14
@cjerad cjerad marked this pull request as ready for review November 17, 2022 21:14
@cjerad cjerad requested a review from a team as a code owner November 17, 2022 21:14
Copy link
Contributor

@snay2 snay2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the review we did on #706 and in offline conversation with @cjerad about the additional changes to add versioning, this looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants