Skip to content

Conversation

cjerad
Copy link
Contributor

@cjerad cjerad commented May 26, 2022

Issue #, if available:

The "grouped targets" feature requires Make 4.3 or newer.

Description of changes:

  • Added check for Make 4.3 or newer in Makefile
  • Updated test workflow
  • Added shortcut make target explore-test-coverage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cjerad cjerad requested a review from brycahta May 26, 2022 14:52
@cjerad cjerad marked this pull request as ready for review May 26, 2022 14:52
@cjerad cjerad requested a review from a team as a code owner May 26, 2022 14:52
Copy link
Contributor

@brycahta brycahta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the explore-test-coverage target, but I don't agree with grouped targets and requiring a specific Make version. It makes the Makefile more difficult to read and less explicit, what's the benefit?

@brycahta brycahta requested a review from pdk27 May 26, 2022 16:23
@pdk27
Copy link
Contributor

pdk27 commented May 26, 2022

Agree with @brycahta. The current version is more readable 👍 .

@cjerad cjerad merged commit f5d9dc3 into aws:v2 May 27, 2022
@cjerad cjerad deleted the feat-explore-test-coverage branch May 27, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants