Skip to content

Conversation

stevehipwell
Copy link
Contributor

Fixes #500.

Description of changes:

  • Remove the setting of hostPort in Deployment
  • Fix PSP to only set hostPorts if needed
  • Fix PSP to work with enableProbesServer: true

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@stevehipwell
Copy link
Contributor Author

/assign @bwagner5

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@bwagner5 bwagner5 merged commit 2d08de0 into aws:main Oct 13, 2021
@stevehipwell stevehipwell deleted the helm-chart-host-port-fix branch October 18, 2021 08:07
@stevehipwell
Copy link
Contributor Author

@bwagner5 I thought that chart changes here were automatically PRed into aws/eks-charts? I can't see a PR for these changes that have been released in v1.34.4.

@snay2
Copy link
Contributor

snay2 commented Oct 18, 2021

@stevehipwell You are correct. The PR is supposed to be created automatically, but that step of the build failed on Friday. Re-running now and will debug if it fails again.

@bwagner5
Copy link
Contributor

Released! Apologies for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart is setting hostPort on deployment
3 participants