Skip to content

Conversation

brycahta
Copy link
Contributor

Issue #, if available: #424

Description of changes:

  • Upgrade to go 1.16
  • Fixed files failing go-report-card

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brycahta brycahta requested a review from bwagner5 May 10, 2021 17:56
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@brycahta
Copy link
Contributor Author

Same issue that was brought up in a past PR.

ineffassign fails with 0% , but running locally it returns 100%. If I run just ineffassign locally it returns no results meaning no issue. My guess is re-running the workflow may pass.

I think the deprecated gometalinter which is being used to run ineffassign here is a potential root cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants