Skip to content

Update ClusterRole to include 'get' for pods #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 26, 2021
Merged

Update ClusterRole to include 'get' for pods #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ac8c50e
Update ClusterRole to include 'get' for pods
imuqtadir Mar 25, 2021
cdd8a71
retrigger tests
imuqtadir Mar 26, 2021
d075367
retrigger test
imuqtadir Mar 26, 2021
1784aa5
Update clusterrole.yaml
imuqtadir Mar 26, 2021
60206a1
Increase sleep time so the pods could be evicted
imuqtadir Mar 26, 2021
446ac72
remove get permissions for pods
imuqtadir Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/helm/aws-node-termination-handler/templates/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ rules:
- pods
verbs:
- list
- get
- apiGroups:
- ""
resources:
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/prometheus-metrics-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ PORT_FORWARD_PID=$!
trap 'kill ${PORT_FORWARD_PID}' EXIT SIGINT SIGTERM ERR
echo "✅ Port-forwarded pod $POD_NAME"

sleep 1
sleep 30

METRICS_RESPONSE=$(curl -L localhost:7000/metrics)
echo "✅ Fetched /metrics."
Expand Down