Skip to content

Conversation

imuqtadir
Copy link
Contributor

@imuqtadir imuqtadir commented Mar 2, 2021

Issue #, if available:

Description of changes: Add node name label to webhoook by default. We don't need to update existing logic of combinedData within webhook.go as we are already stitching the data from InterruptionEvent event which has NodeName

Sample Webhook Content from e2e tests:

{"Content":"[NTH][Instance Interruption] InstanceId: i-1234567890abcdef0 - Node: e2e-test-0662b2f2-worker - InstanceType: m4.xlarge - Kind: SPOT_ITN - Start Time: 2021-03-02 18:02:00 +0000 UTC"}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@imuqtadir imuqtadir requested a review from bwagner5 March 2, 2021 21:43
@imuqtadir imuqtadir linked an issue Mar 2, 2021 that may be closed by this pull request
@imuqtadir imuqtadir self-assigned this Mar 2, 2021
@imuqtadir
Copy link
Contributor Author

Added node name here instead of Node label :(

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants