Drop sqs messages for absent nodes #375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #367, if available:
Description of changes:
If no instances are returned from the describe instances call then there's no work to do, so we'll return a
ErrNodeStateNotRunningerror. This gets handled in theMonitorfunction - it'll delete the message and avoid the panic.With this we can also remove the
if nodeName == "" {check in asg-lifecycle-event because we never actually run that. There's always a nodename by that point or we'll have already returned an error.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.