Clarify podTerminationGracePeriod docs #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabegorelick
force-pushed
the
gracePeriod-default-docs
branch
from
f70ae0f to
6f8922e
Compare
|
@bwagner5 Sorry, I rebased right after you merged. |
|
No worries, looks good! |
haugenj
pushed a commit
to haugenj/aws-node-termination-handler
that referenced
this pull request
Feb 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #348
Description of changes: Clarify that grace period defaults to -1, not 30. But Kubernetes defaults to 30.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. ✅
@bwagner5 Let me know if you want to tweak the language.