Add debug log messages to isInstanceManaged
#274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds debug log messages to give hints when an Auto Scaling Group is not tagged as managed. Without this change there's no other indication that the instance & ASG is unmanaged and makes diagnosing this condition quite difficult without reading through the source code.
bwagner5
reviewed
Nov 3, 2020
Change `Auto Scaling Instance` to `Auto Scaling Group`.
Codecov Report
@@ Coverage Diff @@
## main #274 +/- ##
==========================================
+ Coverage 77.40% 77.50% +0.10%
==========================================
Files 15 15
Lines 1071 1076 +5
==========================================
+ Hits 829 834 +5
Misses 208 208
Partials 34 34
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds debug log messages to give hints when an Auto Scaling
Group is not tagged as managed. Without this change there's no other
indication that the instance & ASG is unmanaged and makes diagnosing
this condition quite difficult without reading through the source code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.