Skip to content

Conversation

bwagner5
Copy link
Contributor

Issue #, if available:
#147

Description of changes:
Fix bug where scheduled maintenance events times were parsed wrong. This would cause scheduled event handling to fail when the date of the start or end time was a 1 digit day. We were assuming the day digit would always be padded with a 0 to make it two digits.

Updated the test and date parsing string.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from haugenj April 30, 2020 14:25
@bwagner5 bwagner5 self-assigned this Apr 30, 2020
@codecov-io
Copy link

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files           8        8           
  Lines         620      620           
=======================================
  Hits          590      590           
  Misses         18       18           
  Partials       12       12           
Impacted Files Coverage Δ
pkg/interruptionevent/scheduled-event.go 93.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 839ee86...3552160. Read the comment docs.

@jillmon jillmon self-requested a review April 30, 2020 14:43
@bwagner5 bwagner5 merged commit 3cb9309 into aws:master Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants