Skip to content

Added automated integration tests runs on github (requires approval) #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Added automated integration tests runs on github (requires approval) #112

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ee8e42
Added automated integration tests runs on github
mbfreder Feb 20, 2024
086db5b
Fix typo
mbfreder Feb 21, 2024
04428c1
Renamed environment to prod
mbfreder Feb 21, 2024
74c7d40
Upgrade actions/checkout to V4
mbfreder Feb 23, 2024
2219d66
Run integ tests without sudo
mbfreder Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/integ-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Run Integration Tests

on:
pull_request:
branches:
- develop

jobs:
integ-tests:
runs-on: ubuntu-latest
environment:
name: integ-tests
steps:
- uses: actions/checkout@v3
Copy link
Contributor

@valerena valerena Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine most of the examples out there use @v3, but @v4 is the latest version available, and it avoids this warning that you can see in your runs:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Copy link
Contributor Author

@mbfreder mbfreder Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

- uses: actions/setup-python@v5
with:
python-version: '3.11'
- name: allows us to build amr64 images
run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
- name: run integration tests
run: sudo make integ-tests-with-docker
Copy link
Contributor

@valerena valerena Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we (or why do we) need to run it with sudo ?

Copy link
Contributor Author

@mbfreder mbfreder Feb 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work without it. I ran into some permissions issue when I tried. Even on my dev desktop I have to use it.

make integ-tests
make[1]: Entering directory `/local/home/mbfreder/Tooling/aws-lambda-runtime-interface-emulator'
python3 -m venv .venv
Error: [Errno 13] Permission denied: '/local/home/mbfreder/Tooling/aws-lambda-runtime-interface-emulator/.venv/bin/activate.csh'