Added automated integration tests runs on github (requires approval) #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerena
reviewed
Feb 22, 2024
.github/workflows/integ-tests.yml
Outdated
| environment: | ||
| name: prod | ||
| steps: | ||
| - uses: actions/checkout@v3 |
There was a problem hiding this comment.
I imagine most of the examples out there use @v3, but @v4 is the latest version available, and it avoids this warning that you can see in your runs:
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
.github/workflows/integ-tests.yml
Outdated
| - name: allows us to build arm64 images | ||
| run: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes | ||
| - name: run integration tests | ||
| run: sudo make integ-tests-with-docker |
There was a problem hiding this comment.
do we (or why do we) need to run it with sudo ?
There was a problem hiding this comment.
It doesn't work without it. I ran into some permissions issue when I tried. Even on my dev desktop I have to use it.
make integ-tests
make[1]: Entering directory `/local/home/mbfreder/Tooling/aws-lambda-runtime-interface-emulator'
python3 -m venv .venv
Error: [Errno 13] Permission denied: '/local/home/mbfreder/Tooling/aws-lambda-runtime-interface-emulator/.venv/bin/activate.csh'
|
I ran some tests on my fork and can confirm that the workflow doesn't run on the main repo. |
valerena
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Tests:
In order to test, we need to create a dummy PR and verify the following:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.