-
Notifications
You must be signed in to change notification settings - Fork 59
Fabisev/artifact publishing #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
fabisev
wants to merge
30
commits into
main
Choose a base branch
from
fabisev/artifact-publishing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
51be34d
Creating github actions workflow with publishing pipeline
88a021d
Adding Copyright headers, header checking script and header writing s…
98ab5eb
Adding rc publishing
5bdfeb3
Commenting lint for now
faaa65f
Testing release
1dc8f90
Adding automated changelog generation
f8c8ad5
Refactoring automated changelog generation
39ab54c
Adding codebuild to the build
5e88c22
Adding the necessary dependencies for codebuild
a9d4d66
Fixing build
5a8defe
Fixing build
86b1fe4
Checking npm publishing
cdc0773
Changing the codebuild
9770fa8
Testing npm publishing using codebuild
0cae97e
Adding logs
eeecccb
Checking build on codebuild
e69a19d
Fixing build on codebuild
3bcd7ea
Fixing build on codebuild
cad8992
Fixing build on codebuild
c645473
Preparing github actions workflow for merge with main
201b966
Solving conflicts
bdb6bf1
Changing npm publishing
331b87e
removing shebang line
7e18147
Adding echo for easier debugging and check if docker is avail
d731168
Adding specific error message for different node versions and formatiing
523de7c
Adding build and publishing for both architectures
160d714
Making the add and check headers scripts use git diff and patches
595e7e8
Making headers scripts use patch files
50265d9
Adding architecture specific tar
f4994c9
FIxing build
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,183 @@ | ||
name: Build and Release | ||
|
||
on: | ||
push: | ||
branches: [ main ] | ||
tags: [ 'v*', 'rc-*' ] | ||
pull_request: | ||
branches: [ main ] | ||
workflow_dispatch: | ||
|
||
permissions: | ||
id-token: write | ||
contents: read | ||
|
||
jobs: | ||
get-version: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
version: ${{ steps.version.outputs.version }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Get version | ||
id: version | ||
run: | | ||
BASE_VERSION=$(node -p "require('./package.json').version") | ||
echo "version=$BASE_VERSION" >> $GITHUB_OUTPUT | ||
|
||
build: | ||
needs: [get-version] | ||
timeout-minutes: 30 | ||
strategy: | ||
matrix: | ||
include: | ||
- arch: x86_64 | ||
runner: codebuild-project-awsaws-lambda-nodejs-runtime-interface-client-${{ github.run_id }}-${{ github.run_attempt }} | ||
- arch: aarch64 | ||
runner: codebuild-project-awsaws-lambda-nodejs-runtime-interface-client-${{ github.run_id }}-${{ github.run_attempt }} | ||
runs-on: ${{ matrix.runner }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Setup Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20' | ||
|
||
- name: Install build dependencies | ||
run: | | ||
apt-get update | ||
apt-get install -y cmake make g++ autotools-dev automake libtool | ||
|
||
- name: Build natively for $(arch) | ||
run: | | ||
echo "Building for architecture: $(arch)" | ||
CURRENT_ARCH=$(arch) | ||
|
||
# Build native dependencies and JavaScript (this creates dist/node14 and dist/node16) | ||
BUILD=1 npm install | ||
npm run build | ||
|
||
# Verify required files were created | ||
if [ ! -f "dist/rapid-client.node" ] || [ ! -f "dist/index.mjs" ] || [ ! -f "dist/UserFunction.js" ]; then | ||
echo "Error: Required files not found in dist directory" | ||
exit 1 | ||
fi | ||
|
||
# Copy architecture-specific package.json to dist | ||
node -e " | ||
const pkg = require('./package.json'); | ||
pkg.name = 'aws-lambda-ric-' + process.env.CURRENT_ARCH; | ||
require('fs').writeFileSync('./dist/package.json', JSON.stringify(pkg, null, 2)); | ||
" CURRENT_ARCH=$CURRENT_ARCH | ||
|
||
# Create tarball with only required files | ||
tar -czf aws-lambda-ric-$CURRENT_ARCH-${{ needs.get-version.outputs.version }}.tgz \ | ||
-C dist package.json index.mjs UserFunction.js rapid-client.node | ||
|
||
- name: Generate checksums | ||
run: | | ||
CURRENT_ARCH=$(arch) | ||
PACKAGE_FILE="aws-lambda-ric-$CURRENT_ARCH-${{ needs.get-version.outputs.version }}.tgz" | ||
sha256sum $PACKAGE_FILE > checksums-$CURRENT_ARCH.sha256 | ||
sha512sum $PACKAGE_FILE > checksums-$CURRENT_ARCH.sha512 | ||
echo "Package: $PACKAGE_FILE ($CURRENT_ARCH) with version: ${{ needs.get-version.outputs.version }}" > checksums-$CURRENT_ARCH.txt | ||
|
||
- name: Upload artifacts | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: package-${{ matrix.arch }}-${{ needs.get-version.outputs.version }} | ||
path: | | ||
aws-lambda-ric-*-${{ needs.get-version.outputs.version }}.tgz | ||
checksums-* | ||
retention-days: 30 | ||
|
||
test: | ||
needs: [get-version, build] | ||
strategy: | ||
matrix: | ||
node-version: [18, 20, 22] | ||
include: | ||
- arch: x86_64 | ||
runner: ubuntu-latest | ||
- arch: aarch64 | ||
runner: ubuntu-latest | ||
runs-on: ${{ matrix.runner }} | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Run unit tests - Node ${{ matrix.node-version }} (native $(arch)) | ||
run: | | ||
docker build \ | ||
-f test/unit/Dockerfile.nodejs${{ matrix.node-version }}.x \ | ||
-t unit/nodejs.${{ matrix.node-version }}x \ | ||
. | ||
docker run --rm unit/nodejs.${{ matrix.node-version }}x | ||
|
||
publish: | ||
if: startsWith(github.ref, 'refs/tags/') | ||
runs-on: codebuild-project-awsaws-lambda-nodejs-runtime-interface-client-${{ github.run_id }}-${{ github.run_attempt }} | ||
needs: [get-version, build, test] | ||
permissions: | ||
contents: write | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Download x86_64 artifacts | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: package-x86_64-${{ needs.get-version.outputs.version }} | ||
path: ./artifacts/x86_64 | ||
|
||
- name: Download aarch64 artifacts | ||
uses: actions/download-artifact@v4 | ||
with: | ||
name: package-aarch64-${{ needs.get-version.outputs.version }} | ||
path: ./artifacts/aarch64 | ||
|
||
- name: Setup Node.js | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: '20' | ||
|
||
- name: Setup NPM authentication | ||
run: | | ||
NPM_TOKEN=$(aws secretsmanager get-secret-value --secret-id aws-lambda-runtimes/github/nodejs/npm-token --query SecretString --output text) | ||
echo "//registry.npmjs.org/:_authToken=${NPM_TOKEN}" > .npmrc | ||
chmod 0600 .npmrc | ||
|
||
- name: Determine version and publish packages | ||
id: version | ||
run: | | ||
if [[ "${{ github.ref }}" == refs/tags/rc-* ]]; then | ||
RC_NUMBER=${GITHUB_REF#refs/tags/rc-} | ||
PACKAGE_VERSION="${{ needs.get-version.outputs.version }}-rc.${RC_NUMBER}" | ||
echo "package_version=$PACKAGE_VERSION" >> $GITHUB_OUTPUT | ||
echo "is_rc=true" >> $GITHUB_OUTPUT | ||
TAG_FLAG="--tag rc" | ||
else | ||
echo "package_version=${{ needs.get-version.outputs.version }}" >> $GITHUB_OUTPUT | ||
TAG_FLAG="" | ||
fi | ||
|
||
# Publish architecture-specific packages | ||
for arch in x86_64 aarch64; do | ||
PACKAGE_FILE=$(ls ./artifacts/$arch/aws-lambda-ric-$arch-*.tgz) | ||
echo "Publishing $PACKAGE_FILE for architecture $arch" | ||
npm publish $PACKAGE_FILE $TAG_FLAG --access=public | ||
done | ||
|
||
- name: Combine checksums | ||
run: | | ||
cat ./artifacts/*/checksums-*.txt > combined-checksums.txt | ||
cat ./artifacts/*/checksums-*.sha256 > combined-checksums.sha256 | ||
cat ./artifacts/*/checksums-*.sha512 > combined-checksums.sha512 | ||
|
||
- name: Create GitHub Release | ||
if: startsWith(github.ref, 'refs/tags/') | ||
uses: softprops/action-gh-release@v2 | ||
with: | ||
files: | | ||
./artifacts/*/aws-lambda-ric-*-*.tgz | ||
combined-checksums.* | ||
prerelease: ${{ steps.version.outputs.is_rc }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the general flow of this is different from what we did
--access=public