-
Notifications
You must be signed in to change notification settings - Fork 568
Add support for type-safe Start* function #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
f0c1e5b
add HandlerFunc interface and StartWithOptionsTypeSafe
logandavies181 3626bc5
add tests for StartWithOptionsTypeSafe
logandavies181 ec79835
Update test to cover bool from validateArguments
logandavies181 1bb0745
move generic code to dedicated files with build tag
logandavies181 0196bd7
Reduce HandlerFunc interface to just one variant. Rename StartWithOpt…
logandavies181 bc1e02e
add ValidateHandlerFunc
logandavies181 2b3ddd9
Revert "add ValidateHandlerFunc"
logandavies181 770cbab
add context-arg-only reflections back to the godoc
bmoffatt c51f5fe
update copyright date in new file to match year of file's creation
bmoffatt e81678e
update copyright year in new test file to match the year of file's cr…
bmoffatt File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
//go:build go1.18 | ||
// +build go1.18 | ||
|
||
// Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved | ||
|
||
package lambda | ||
|
||
import ( | ||
"context" | ||
) | ||
|
||
// HandlerFunc represents a valid input with two arguments and two returns as described by Start | ||
type HandlerFunc[TIn, TOut any] interface { | ||
func(context.Context, TIn) (TOut, error) | ||
} | ||
|
||
// StartHandlerFunc is the same as StartWithOptions except that it takes a generic input | ||
// so that the function signature can be validated at compile time. | ||
// | ||
// Currently only the `func (context.Context, TIn) (TOut, error)` variant is supported | ||
func StartHandlerFunc[TIn any, TOut any, H HandlerFunc[TIn, TOut]](handler H, options ...Option) { | ||
start(newHandler(handler, options...)) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
//go:build go1.18 | ||
// +build go1.18 | ||
|
||
// Copyright 2022 Amazon.com, Inc. or its affiliates. All Rights Reserved | ||
|
||
package lambda | ||
|
||
import ( | ||
"context" | ||
"fmt" | ||
"reflect" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
) | ||
|
||
func TestStartHandlerFunc(t *testing.T) { | ||
actual := "unexpected" | ||
logFatalf = func(format string, v ...interface{}) { | ||
actual = fmt.Sprintf(format, v...) | ||
} | ||
|
||
f := func(context.Context, any) (any, error) { return 1, nil } | ||
StartHandlerFunc(f) | ||
|
||
assert.Equal(t, "expected AWS Lambda environment variables [_LAMBDA_SERVER_PORT AWS_LAMBDA_RUNTIME_API] are not defined", actual) | ||
|
||
handlerType := reflect.TypeOf(f) | ||
|
||
handlerTakesContext, err := validateArguments(handlerType) | ||
assert.NoError(t, err) | ||
assert.True(t, handlerTakesContext) | ||
|
||
err = validateReturns(handlerType) | ||
assert.NoError(t, err) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.