fix: Use the ILambdaSerializer to serialize the response body when returning an IHttpResult and generate documentation comments for public members #1748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e '<auto-generated/>' hint
96malhar
commented
May 13, 2024
Comment on lines
-25
to
-26
| [JsonSerializable(typeof(APIGatewayHttpApiV2ProxyRequest))] | ||
| [JsonSerializable(typeof(APIGatewayHttpApiV2ProxyResponse))] |
Contributor
Author
There was a problem hiding this comment.
Since the lambda function returns an IHttpResult, it does not need to serialize these types.
normj
approved these changes
May 13, 2024
Member
normj
left a comment
normj
left a comment
There was a problem hiding this comment.
You could also add the version bump as well to the PR but the changes look good.
ashovlin
reviewed
May 14, 2024
Libraries/src/Amazon.Lambda.Annotations/APIGateway/HttpResults.cs
Outdated
Show resolved
Hide resolved
Libraries/test/Amazon.Lambda.Annotations.SourceGenerators.Tests/SourceGeneratorTests.cs
Show resolved
Hide resolved
...ambda.Annotations.SourceGenerators.Tests/Snapshots/FunctionsZipOutput_ToLower_Generated.g.cs
Outdated
Show resolved
Hide resolved
ashovlin
approved these changes
May 14, 2024
…turning an IHttpResult BREAKING CHANGE: Removed the JsonContext property in the HttpResultSerializationOptions class and replaced it with an ILambdaSerializer
96malhar
force-pushed
the
kmalhar/annotations-updates
branch
from
875b874 to
d5211a3
Compare
This was referenced May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
ILambdaSerializerto serialize the response body when returning anIHttpResultJsonContextproperty in theHttpResultSerializationOptionsclass and replaced it with anILambdaSerializerBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.