fix: run GlobalToolInstallAction in a lock block and only once #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgrandis
reviewed
Dec 10, 2020
mgrandis
reviewed
Dec 10, 2020
elbayaaa
reviewed
Dec 10, 2020
elbayaaa
reviewed
Dec 10, 2020
elbayaaa
approved these changes
Dec 10, 2020
mgrandis
approved these changes
Dec 11, 2020
mndeveci
added a commit
that referenced
this pull request
Jan 12, 2021
* Added Dynamic Encoding Selection Based on Windows System Default * Fixed dotnet output system dependent encoding * Updated test_custom_make urllib3 Version * Reformatted with black * Rollback Changes to popen for Python 2 Support * Added Doc Page for DotNet Output Encoding * fix(ruby): use stdout stream to raise exceptions from bundler - relevant error information is in stdout instead of stderr for bundler. * chore: bump version to 1.1.0 * chore: Upgrade pytest to 6.1.1 * chore: Upgrade mock to 4.0.2 * chore: Upgrade parameterize to 0.7.4 * chore: Upgrade coverage to 5.3 * chore: Upgrade flake8 to 3.8.4 * chore: Upgrade pylint to 2.6.0 * Consider using Python 3 style super() without arguments (super-with-arguments) * Implicit string concatenation found in assignment (implicit-str-concat) * Consider explicitly re-raising using the 'from' keyword (raise-missing-from) * Only install backports.tempfile for 2.7 & 3.6 * python 2 fallbacks (pylint & mock) * Revert "Consider using Python 3 style super() without arguments (super-with-arguments)" This reverts commit 44284ea. * Revert "Consider explicitly re-raising using the 'from' keyword (raise-missing-from)" This reverts commit cd7c16e. * Disable rules that affecting Python 2 * Manage black version using requirement file (#207) * chore: Manage black version in dev.txt * chore: Update appveyor, use black in pip * chore: Add pre-commit-config * chore: Format with black 20.8b1 * chore: Add make pr2.7 for Python 2 that does not run black * chore: Remove python patch version in AppVeyor to be more robust (#213) * chore: Remove biased language (#212) * fix: run GlobalToolInstallAction in a lock block and only once (#214) * fix: run GlobalToolInstallAction in a lock block and only once * chore: change field name and update unit tests * chore: black formatting * fix: change tests to use threadpool for py2 * chore: update assert call and change usage of Executor * chore: bump version to 1.2.0 (#218) Co-authored-by: Wilton Wang <[email protected]> Co-authored-by: Sriram Madapusi Vasudevan <[email protected]> Co-authored-by: Sriram Madapusi Vasudevan <[email protected]> Co-authored-by: Sam Liu <[email protected]> Co-authored-by: _sam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#211
Description of changes:
This change is adding a lock and an installation flag to GlobalToolInstallAction, to run it only once when it has run in a parallel build process.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.