Simplify samples #649
Open
Simplify samples #649
+2
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
reviewed
Sep 19, 2025
| optional arguments: | ||
| --client_id Client ID (default: mqtt5-sample-5873a450) | ||
| --ca_file Path to optional CA bundle (PEM) (default: None) |
There was a problem hiding this comment.
I think --ca_file parameter was mentioned in our scripts/docs. We probably wanna update those with the change as well.
Sorry I didn't realize there is another PR for the sample changes, should've reviewed before the previous PR >.<
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove additional options from sample to simplify their use. Addition of things like ports, rootca, http proxy can be found in the userguide for people who want to use them.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.