Skip to content

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Sep 30, 2025

Issue #, if available:

Description of changes:

  1. Add CI job to validate required files
  2. Remove old samples

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xiazhvera xiazhvera changed the title [WIP]Add CI to validate required files Add CI to validate required files Oct 1, 2025
documents/FAQ.md Outdated

```sh
mvn compile exec:java -pl samples/Mqtt/Mqtt5X509 -Daws.crt.debugnative=true -Daws.crt.log.level=Debug -Daws.crt.log.destionation=Stdout -Dexec.mainClass=pubsub.PubSub -Dexec.args='--endpoint <endpoint> --cert <path to cert> --key <path to key>'
mvn compile exec:java -pl samples/Mqtt/Mqtt5X509 -Daws.crt.debugnative=true -Daws.crt.log.level=Debug -Daws.crt.log.destionation=Stdout -Dexec.mainClass=mqtt5x509.Mqtt5X509 -Dexec.args='--endpoint <endpoint> --cert <path to cert> --key <path to key>'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new samples have been adjusted to no longer need -Dexec.mainClass=mqtt5x509.Mqtt5X509. This example command should be simplified to:
mvn compile exec:java
-pl samples/Mqtt/Mqtt5X509
-Dexec.args="
--endpoint
--cert
--key "

Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the description of the PR from its default to what we're doing here. Fix addressed comments and ship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants