Enhance samples #657
Open
Enhance samples #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiazhvera
reviewed
Sep 11, 2025
samples/Mqtt/X509PubSub/src/main/java/x509pubsub/X509PubSub.java
Outdated
Show resolved
Hide resolved
xiazhvera
reviewed
Sep 11, 2025
| String certPath; | ||
| String keyPath; | ||
| String caPath = null; | ||
| String clientId = "mqtt5-sample-" + UUID.randomUUID().toString().replace("-", "").substring(0, 8); |
There was a problem hiding this comment.
"mqtt5-sample-" was used for client id prefix, while the policy in README should updated to be
"Resource": [
"arn:aws:iot:<b>region</b>:<b>account</b>:client/mqtt5-sample-*"
]
```
xiazhvera
reviewed
Sep 12, 2025
samples/Mqtt/X509PubSub/src/main/java/x509pubsub/X509PubSub.java
Outdated
Show resolved
Hide resolved
xiazhvera
reviewed
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update and improve existing samples and documentation
Remove Codebuild Sample Smoketest from CI
Remove Greengrass CI job
Add Samples:
MQTT5 AWS Websocket
MQTT5 Custom Unsigned Auth
MQTT5 Custom Signed Auth
MQTT5 PKCS11
Update Sample READMEs
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.