feat: change KMS discovery keyring configuration path #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seebees
requested changes
Mar 25, 2020
|
| raise TypeError("is_discovery cannot be True if key IDs are provided") | ||
|
|
||
| if neither: | ||
| raise TypeError("No key IDs provided") |
There was a problem hiding this comment.
You could mention discovery in the error message, something like "Key IDs are required for non-discovery KMS Keyrings.", so the user knows about discovery if they actually didn't want to supply key ids
There was a problem hiding this comment.
There was a problem hiding this comment.
ah, misread that; actually in the error message. Sure.
WesleyRosenblum
approved these changes
Mar 25, 2020
seebees
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
resolves #227
Description of changes:
Reasoning is described in #227 and awslabs/aws-encryption-sdk-specification#84.
The short version is that rather than discovery being a derived property that is the result of an absence of key IDs, discovery is now an explicit parameter that is incompatible with key IDs being supplied.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: