Skip to content

[keyring] add is_discovery parameter to KMS keyring #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mattsb42-aws opened this issue Mar 25, 2020 · 0 comments
Closed

[keyring] add is_discovery parameter to KMS keyring #227

mattsb42-aws opened this issue Mar 25, 2020 · 0 comments
Assignees
Milestone

Comments

@mattsb42-aws
Copy link
Member

I originally had discovery defined as a derived property in the KMS keyring because that is how we currently have it defined in the spec. However, all of the other KMS keyring implementations have it as an explicit parameter, and after discussing it with the team we decided that was the correct UX. As such, we'll be updating the spec accordingly[1] and we need to update this KMS keyring before release.

[1] awslabs/aws-encryption-sdk-specification#84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant