Skip to content

[keyring] Verify that KMS keyring behaves correctly on encrypt #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattsb42-aws opened this issue Mar 13, 2020 · 2 comments
Closed

[keyring] Verify that KMS keyring behaves correctly on encrypt #222

mattsb42-aws opened this issue Mar 13, 2020 · 2 comments
Milestone
keyrings

Comments

@mattsb42-aws
Copy link
Member

Once awslabs/aws-encryption-sdk-specification#73 is resolved, we need to verify that the KMS keyring implementation is correct.
@mattsb42-aws mattsb42-aws added this to the keyrings milestone Mar 17, 2020
@mattsb42-aws
Copy link
Member Author

Something I realized as I was working through this: the current behavior of adding EDKs as we get them violates the spec requirement that if any CMKs fail, the KMS keyring MUST NOT modify the encryption materials.

I think that the simplest way to do the right thing here will be to implement #214.

@mattsb42-aws
Copy link
Member Author

With the changes implemented in #231 and and the spec changes made in awslabs/aws-encryption-sdk-specification#74, this implementation now matches the specification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
keyrings
Development

No branches or pull requests
1 participant
@mattsb42-aws