Skip to content

docs: Add versioning file #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 4, 2019
Merged

docs: Add versioning file #224

merged 4 commits into from
Oct 4, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Oct 3, 2019

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@seebees seebees requested a review from a team October 3, 2019 23:01
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also like @SalusaSecondus to take a look at this.
I like this direction, but he had thoughts on our versioning policies elsewhere.

VERSIONING.md Outdated
Comment on lines 24 to 25
What this means for you
=======================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs markdown-style heading notation.

lizroth
lizroth previously approved these changes Oct 4, 2019
Copy link

@lizroth lizroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like our versioning policies to be consistent across all of our libraries. I don't think this is different enough to warrant show stopping at this time. Conventional Commits seem very compelling to me.

I found a minor words thing, but otherwise I am happy enough with this to Approve.

Merging should wait for @SalusaSecondus and any follow-up thoughts @mattsb42-aws has now that the Markdownization is done. :)

@SalusaSecondus
Copy link

  1. Conventional commits seems like a neat idea and depending on how it works here may be worth rolling out more widely
  2. The other ESDKs don't follow semantic versioning and so if this does, it will be different. See the java VERSIONING file as an example. Minor changes are permitted backwards incompatible changes which can be:
    a. Usually be ignored because they are rarely encountered/edge-case, and
    b. Can be automatically picked up by any system with a reasonable set of unit-/integration-tests, and
    c. (If not extremely urgent) are warned with deprecation notices in a prior Minor/Patch release

@seebees seebees changed the title doc: Add versioning file docs: Add versioning file Oct 4, 2019
Copy link

@lizroth lizroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

VERSIONING.md Outdated
A patch release will also include warning of upcoming breaking changes, whenever possible.

# What this means for you

We recommend running the most recent version. Here are our suggestions for managing updates:

* X changes will require some effort to incorporate.
* Y changes will not require significant effort to incorporate.

* If you have good unit and integration tests, these changes are generally safe to pick up automatically.

* Z changes will not require any changes to your code. Z changes are intended to be picked up automatically.

* Good unit and integration tests are always recommended.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could have left these as expressions of our intent (especially the bit about if we know we will need to make breaking changes soon, we will make an effort to warn you), but I don't think removing them is a problem either, given that we're stating our use of CC/SemVer.

@SalusaSecondus
Copy link

To be clear. My concerns aside, I have no objections to us moving forward with this proposed versioning scheme.

@seebees seebees merged commit 715aba5 into aws:master Oct 4, 2019
@seebees seebees deleted the versioning-file branch October 4, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants