Skip to content

feat: Remove unencryptedDataKeyLength #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2019

Conversation

seebees
Copy link
Contributor

@seebees seebees commented Aug 28, 2019

It is a feature that is not being used.
This was created to let callers confirm that the unencrypted data key matched the algorithm suite,
but this checking is done directly into the cryptographic material now.
The hasUnencryptedDataKey is the best way to check for existence,
and the materials themselves will ensure that algorithm suite specifications are meet.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

It is a feature that is not being used.
@seebees seebees requested a review from a team August 28, 2019 04:32
Copy link
Member

@mattsb42-aws mattsb42-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the understanding that this represents a breaking change and that needs to be reflected in the next release version.

@seebees
Copy link
Contributor Author

seebees commented Sep 6, 2019

NOTE: This breaking change is ONLY done because the project is in beta.
Otherwise there would be a major version bump.

@seebees seebees merged commit bd160c0 into aws:master Sep 6, 2019
@seebees seebees deleted the remove-unencrypted_data_key_length branch September 6, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants