separate module for examples #33
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately it looks like this branch currently conflicts and can't be merged. There are also some other changes in e.g. PR #40 that will touch those same files soon, so it's best not to rebase just yet. That being said, I'm thinking the better approach here would be to move them off to a separate repo - I don't want to have the version number in multiple places and add more levels of directories to the source tree if we can avoid it. I'll look into getting a new repo set up on our side. |
|
Closing this PR for now, we'll track the progress in #32 until we can finish setting up the new examples repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #32
Please review. I'll incorporate your feedbacks in my next commit.
FYI @bdonlan