Skip to content

chore: Run CodeBuild CI from Github Actions #737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2023
Merged

Conversation

lucasmcdonald3
Copy link
Contributor

Issue #, if available:

Description of changes:

  • Delete buildspec.yml
  • Create .github/workflows/run-codebuild-ci.yml. This implements the CodeBuild CI workflow from buildspec.yml as a Github actions workflow running CodeBuild steps.

Testing:

Successful run: https://github.com/aws/aws-dynamodb-encryption-java/actions/runs/3849450101

There will still be a CodeBuild required check on the PR that will fail, as buildspec.yml was removed. I would plan to delete this check from the repo once a reviewer has approved the PR; see release steps below.

Release steps:

Once PR is in a state with provisional approval and a failing CodeBuild check:

  • Delete CodeBuild required check from repo (should remove check from PR)
  • Delete CodeBuild webhook from repo
  • Confirm all checks succeed; get approval + merge in

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@lucasmcdonald3 lucasmcdonald3 requested a review from a team as a code owner January 5, 2023 18:57
ajewellamz
ajewellamz previously approved these changes Jan 5, 2023
Copy link
Contributor

@ajewellamz ajewellamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucasmcdonald3 lucasmcdonald3 merged commit c2896f5 into master Jan 5, 2023
@lucasmcdonald3 lucasmcdonald3 deleted the gha_ci branch January 5, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants