Skip to content

Conversation

@harryfrzz
Copy link

@harryfrzz harryfrzz commented Oct 27, 2025

Issue # (if applicable)

Closes #35717.

Reason for this change

Amazon EKS and EKS Distro now support Kubernetes 1.34. Adding v1.34 to the CDK EKS module keeps CDK users aligned with the latest managed Kubernetes version and avoids manual workarounds.

Description of changes

• Add KubernetesVersion.V1_34 to EKS supported versions.
• Update kubectl asset layer to v1.34 for compatibility with cluster operations.
• Refresh integration test snapshots reflecting kubectl v1.34 outputs.

Describe any new or updated permissions being added

Description of how you validated changes

• Unit tests: Extended version to include v1.34 and ran existing EKS tests.
• Integration: Updated snapshots for kubectl v1.34

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 27, 2025 15:21
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Oct 27, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 27, 2025 15:57

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@phuhung273
Copy link
Contributor

The idea is ok, we can start updating a few things first:

  • Update PR title as instructed in https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request
  • For this PR and next few other PRs, I would recommend to fill all PR description to:
    • help reviewers understand what problem you're solving
    • show how you tested the change
    • Among them, only permission section is optional.
  • Seems like you're using your own linter to format cluster.ts. Please don't do it as the project already has its own linter. Ideally, cluster.ts should only has the new version added.

@harryfrzz harryfrzz changed the title feat: add support for Kubernetes 1.34 feat(aws-eks): support Kubernetes 1.34 Oct 27, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@harryfrzz harryfrzz changed the title feat(aws-eks): support Kubernetes 1.34 feat(eks): support Kubernetes 1.34 Oct 27, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 27, 2025 16:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. labels Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws_eks: Add Support for Kubernetes 1.34

3 participants