Skip to content

Conversation

@mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Jun 25, 2025

Reason for this change

We are migrating integ-runner to use a new engine based of toolkit-lib instead of the CLI. To verify behavior, this engine was added under a new unstable feature flag. Let's use it in a repo that has a lot of traffic for integ-runner but is under own tight control and ownership, so we can easily react if something goes wrong.

Description of changes

Use the new toolkit-lib-engine by delcaring integ-runner --unstable=toolkit-lib-engine on our yarn scripts.

Describe any new or updated permissions being added

n/a

Description of how you validated changes

Tests still pass.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team June 25, 2025 12:13
@github-actions github-actions bot added the p2 label Jun 25, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 25, 2025
@mrgrain mrgrain force-pushed the mrgrain/chore/integ-runner-toolkit-lib branch from 0a9095b to 65db1be Compare June 26, 2025 19:11
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 26, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 27, 2025
@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 149b88d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jun 27, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6a5e7ab into main Jun 27, 2025
18 checks passed
@mergify mergify bot deleted the mrgrain/chore/integ-runner-toolkit-lib branch June 27, 2025 13:13
@github-actions
Copy link
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants