-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(route53): add SVCB and HTTPS resource record classes #34744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Tietew it looks like this PR is pending for some reason. Are you able to re-run the checks (I guess if you rebase on |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34673.
Reason for this change
Route53 supports SVCB and HTTPS resource records and CDK also supports via
route53.RecordType.SVCBandroute53.RecordType.HTTPS.https://aws.amazon.com/about-aws/whats-new/2024/10/amazon-route-53-https-sshfp-svcb-tlsa-dns-support/
HTTPS record can be an alias to CloudFront.
https://aws.amazon.com/about-aws/whats-new/2025/07/amazon-cloudfront-https-dns-records/
It's useful to make a resource class for HTTPS record like
ARecordetc to ensure generating correct record values.Currently, most common usage is to create an HTTPS ServiceMode record with ALPN parameter.
SVCB and HTTPS have same representation format.
Therefore I added both record classes to share implementation.
Description of changes
Added
SvcbRecordandHttpsRecordresource classes and corresponding types.HttpsRecordalso supports CloudFront alias target.Usage
To define SVCB record, just replace
HttpstoSvcb.For details of each parameter, see RFC 9460.
Describe any new or updated permissions being added
N/A
Description of how you validated changes
Unit tests and integ test.
I've confirmed Route53 rejects undefined SvcParam keys such as
key65444=ex2.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license