Skip to content

chore(prlinter): fixing some errors in the needs review workflow #25464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2023
Merged

chore(prlinter): fixing some errors in the needs review workflow #25464

merged 3 commits into from
May 5, 2023

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented May 5, 2023 •
edited
Loading

Fixing some of the remaining issues with the new needs review workflow

  • aws-cdk-automation does show up as MEMBER so need to filter it out
  • If the PR linter failed then we never made it to the assessReview. Make sure we assess review even if the linter fails

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@corymhall
chore(prlinter): fixing some errors in the needs review workflow
cde2cf1 
Fixing some of the remaining issues with the new needs review workflow
@gitpod-io
Copy link

gitpod-io bot commented May 5, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 5, 2023 17:05
@github-actions github-actions bot added the p2 label May 5, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 5, 2023
kaizencc
kaizencc approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay

@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 21be38d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8ef0ba2 into main May 5, 2023
@mergify mergify bot deleted the corymhall/prlinter/always-assess-review branch May 5, 2023 17:53
@mergify
Copy link
Contributor

mergify bot commented May 5, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@corymhall @aws-cdk-automation @kaizencc