chore: npm-check-updates && yarn upgrade #10363
Conversation
Ran npm-check-updates and yarn upgrade to keep the `yarn.lock` file up-to-date. Also updated `yarn-update.yml` to ignore `lambda-tester` since the current major version is incompatible with our minimum `node` requirement (because of a transitive dependency of theirs).
RomainMuller
added
the
dependencies
Changes `eslint-ignore` statements to use the new `@typescript-eslint/no-shadow` rule where they were previously using `no-shadow`. This accomodates the new version of the typescript eslint plugin. Change imports of interfaces from `aws-sdk` from nested modules. The location of these interfaces was changed in a recent release.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
@RomainMuller A recent change in aws-sdk moved a bunch of the config type definitions into a new file. This was done to decrease compile time of TS projects using the sdk. Since we are using these interfaces within the custom resource provider framework runtime code, @iliapolo brought up a good point that this may break depending on the version of the aws-sdk that is available in the lambda runtime. Wondering what next steps we should take here. @aws/aws-cdk-team |
|
@MrArnoldPalmer in the interim you might want to simply exclude |
| /** | ||
| * A Capture object that captures a custom type | ||
| */ | ||
| // eslint-disable-next-line @typescript-eslint/no-shadow |
There was a problem hiding this comment.
is this needed? can't quite tell why if so.
There was a problem hiding this comment.
yeah it is needed because the new typescript-eslint plugin also detects shadowing for generic names. T is apparently shadowed here.
|
Closing in favor of #10402, since this generates a new yarn.lock file. Its easier to reset back to master and upgrade excluding aws-sdk. |
4 participants
Ran npm-check-updates and yarn upgrade to keep the
yarn.lockfileup-to-date.
Also updated
yarn-update.ymlto ignorelambda-testersince thecurrent major version is incompatible with our minimum
noderequirement (because of a transitive dependency of theirs).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license