Skip to content

Conversation

zhu-xiaowei
Copy link
Contributor

Description

  1. add screen view event after session start

General Checklist

  • Added new tests to cover change, if needed
  • Build succeeds using Swift Package Manager
  • All unit tests pass
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Documentation update for the change if required
  • PR title conforms to conventional commit style
  • If breaking change, documentation/changelog update with migration instructions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zhu-xiaowei zhu-xiaowei requested a review from zxkane March 1, 2024 04:03
@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.66%. Comparing base (3f3239b) to head (7cf5820).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
+ Coverage   95.59%   95.66%   +0.07%     
==========================================
  Files          35       35              
  Lines        1973     1986      +13     
==========================================
+ Hits         1886     1900      +14     
+ Misses         87       86       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zxkane zxkane merged commit 63e1df1 into main Mar 1, 2024
@zxkane zxkane deleted the screen-view-after-session-start branch March 1, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants